Skip to content

Native ARM64 CI builds and tests #2581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Native ARM64 CI builds and tests #2581

wants to merge 2 commits into from
+83 −57

Conversation

@Avasam
Copy link
Collaborator

@Avasam Avasam commented Apr 26, 2025 •
edited
Loading

Announcement: https://github.com/orgs/community/discussions/155713

Predecessors / based on:

Changes unique to this PR:

  • Updated artefacts names
  • Add ARM64 to the Build and test job
  • Keep cross-compiling before Python 3.11
  • Updated link in make_all.bat to directly point to cross-compilation info

@Avasam Avasam changed the title Native ARM64 CI wheels Native ARM64 CI tests and wheels Apr 26, 2025
@Avasam Avasam force-pushed the Native-ARM64-CI-wheels branch 2 times, most recently from 7add533 to 22b2594 Compare April 27, 2025 05:10
@Avasam Avasam marked this pull request as draft April 27, 2025 05:13
@Avasam Avasam mentioned this pull request Apr 28, 2025
Merged
@Avasam
Copy link
Collaborator Author

Avasam commented Apr 28, 2025 •
edited
Loading

Alright, I'm getting actual failed tests on ARM64 now. Not too surprising since I doubt many contributors have an AMR64 Windows machine.

I think this is the failing test: https://github.com/mhammond/pywin32/actions/runs/14699426077/job/41246179979?pr=2581#step:11:500

Traceback (most recent call last):
  File "C:\a\pywin32\pywin32\com\win32com\test\testPyComTest.py", line 53, in <module>
    universal.RegisterInterfaces("{6BCDCB60-5605-11D0-AE5F-CADD4C000000}", 0, 1, 1)
  File "C:\Users\runneradmin\AppData\Roaming\Python\Python311-arm64\site-packages\win32com\universal.py", line 76, in RegisterInterfaces
    _doCreateVTable(iid, name, is_dispatch, method_defs)
  File "C:\Users\runneradmin\AppData\Roaming\Python\Python311-arm64\site-packages\win32com\universal.py", line 86, in _doCreateVTable
    vtbl = pythoncom._univgw.CreateVTable(defn, is_dispatch)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
testit (__main__.PyCOMTest.testit) ... FAIL
NotImplementedError: not implemented on this platform

The only matching error message I could find is this:

pywin32/com/win32com/src/univgw.cpp

Lines 264 to 268 in ddc14b2

#else // other arches
/* The MAINWIN toolkit allows us to build this on Linux!!! */
#pragma message("XXXXXXXXX - win32com.universal won't work on this platform - need make_method")
PyErr_SetString(PyExc_NotImplementedError, "not implemented on this platform");
code = NULL;

@Avasam Avasam changed the title Native ARM64 CI tests and wheels Native ARM64 CI builds and tests Apr 30, 2025
@Avasam Avasam marked this pull request as ready for review May 1, 2025 00:19
@Avasam Avasam marked this pull request as draft May 2, 2025 03:46
@Avasam Avasam force-pushed the Native-ARM64-CI-wheels branch from 1a1ac0f to f45a458 Compare October 23, 2025 02:13
@Avasam Avasam marked this pull request as ready for review October 23, 2025 02:14
@Avasam Avasam force-pushed the Native-ARM64-CI-wheels branch from 7e1ad02 to 7500afe Compare October 23, 2025 02:35
@Avasam Avasam requested a review from mhammond October 23, 2025 03:02
@Avasam Avasam mentioned this pull request Oct 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhammond mhammond Awaiting requested review from mhammond

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Avasam